[Bug 483730] Review Request: kde-plasma-translatoid - A Google Translation Plasmoid

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 3 13:29:49 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483730





--- Comment #1 from Jaroslav Reznik <jreznik at redhat.com>  2009-02-03 08:29:48 EDT ---
rpmlint output:

kde-plasma-translatoid.src: E: invalid-spec-name
- missing 's' in spec filename

kde-plasma-translatoid.src: E: no-cleaning-of-buildroot %install
- same as for #483728

kde-plasma-translatoid.src: W: summary-not-capitalized translator using google
translator
- capitalize summary, description too

kde-plasma-translatoid.x86_64: W: spurious-executable-perm
/usr/share/doc/kde-plasma-translatoid-0.4.1/README


kde-plasma-translatoid.x86_64: W: incoherent-version-in-changelog 0.4.1
['0.4.1-1.fc10', '0.4.1-1']
- same as for #483728


- license GPLv2+
- I'm not sure about Google trademarks, let me check
- URL should be
http://www.kde-look.org/content/show.php/translatoid?content=97511
- you should use 97511-translatoid%{version} in Source0 
- remove flags due to Fedora policy
- use build root consistently - rm -rf $RPM_BUILD_ROOT -> rm -rf ${buildroot}

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list