[Bug 477870] Review Request: eclipse-emf - Eclipse Modeling Framework (EMF) Eclipse plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477870





--- Comment #16 from Mat Booth <fedora at matbooth.co.uk>  2009-02-03 16:27:23 EDT ---
(In reply to comment #15)
> (In reply to comment #13)
> > I'll take this review.
> > 
> > Everything looks good to me.  I have a few questions:
> > 
> > - does this comment mean we have reduced functionality?
> > 
> >   "... these files aren't needed for source plugins; they are only needed
> >   "so the example-installer plugins can create full projects in your
> > workspace)"
> > 
> 
> No, nothing is lost. I will change that comment to be clearer. The files are
> still included such that they are present when you create the sample plugin
> projects in your workspace. (They are merely omitted from the associated source
> plugins of the sample plugins in the same way they are omitted from the
> associated source plugins of all other regular plugins.)
> 
> If that makes any sense.
> 
> To see what I mean just try creating some of the EMF sample plugins projects
> through the new example wizard and making sure the .project/.classpath files
> get created.
> 


Oh my gods, there's a reason I'm not a technical writer.

What I mean is, the patch (rightly) excludes those hidden files from the build
process that creates source plugins. They are still present however, when the
sample plugins are bundled to become the sample workspace projects available
from the new->examples wizard within eclipse.

I think that's marginally clearer...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.