[Bug 483543] Review Request: SystemTapGuiServer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483543





--- Comment #2 from William Cohen <wcohen at redhat.com>  2009-02-03 18:26:59 EDT ---
Created an attachment (id=330797)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=330797)
Avoid coding the compiler flags in the Makefile

When RPMs are built through the build system CFLAGS and CXXFLAGS are passed in.
This patch removes the hardcode options. The attached patch shows the changes
in the makefile. I would think that these would be folded into the source file
rather than carried as a patch in the RPM.

The spec file needs minor change to pass in the flags. That will be a separate
attachment.

When compiling with the x86-64 F10 got the following warning during the build
that should be examined more closely:

subscriptionMgr.cpp: In member function 'int
datamanager::SubscriptionMgr::handleRequest(datamanager::dmRequest*,
datamanager::dmResponse*, int)':
subscriptionMgr.cpp:130: warning: 'rc' may be used uninitialized in this
function
datamanager.cpp: In member function 'void
datamanager::DataManager::destroyStapProcess(datamanager::stap_process_t*)':
datamanager.cpp:413: warning: ignoring return value of 'int system(const
char*)', declared with attribute warn_unused_result
datamanager.cpp: In member function 'void
datamanager::DataManager::execStap(datamanager::dmRequest*)':
datamanager.cpp:799: warning: ignoring return value of 'int system(const
char*)', declared with attribute warn_unused_result

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.