[Bug 225958] Merge Review: kbd

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225958


manuel wolfshant <wolfy at nobugconsulting.ro> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |wolfy at nobugconsulting.ro
               Flag|                            |fedora-review?




--- Comment #1 from manuel wolfshant <wolfy at nobugconsulting.ro>  2009-02-03 19:13:13 EDT ---
rpmlint is not really happy at all:
rpmlint of source RPM:
kbd.src:20: W: unversioned-explicit-obsoletes console-tools
kbd.src:20: W: unversioned-explicit-obsoletes open
kbd.src:21: W: unversioned-explicit-provides console-tools
kbd.src:21: W: unversioned-explicit-provides open
kbd.src:23: E: prereq-use initscripts >= 5.86-1
kbd.src:73: E: hardcoded-library-path in
$RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ro_win.map.gz
kbd.src:76: E: hardcoded-library-path in
$RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/sr-latin.map.gz
kbd.src:80: E: hardcoded-library-path in
$RPM_BUILD_ROOT/lib/kbd/keymaps/i386/qwerty/ko.map.gz
kbd.src:109: E: hardcoded-library-path in /lib/kbd
kbd.src: W: no-url-tag

rpmlint of kbd:
kbd.x86_64: W: file-not-utf8 /usr/share/doc/kbd-1.15/ChangeLog
kbd.x86_64: W: no-url-tag


I think that --localedir=/usr/share/locale should be replaced with
--localedir=%_datadir/locale

At least the COPYING file from the root dir should be included as %doc. I
suggest to also add doc/dvorak

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.