[Bug 483859] Review Request: libg3d - Library for 3D file/object viewer
bugzilla at redhat.com
bugzilla at redhat.com
Wed Feb 4 04:50:41 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=483859
Ed Hill <ed at eh3.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |ed at eh3.com
AssignedTo|nobody at fedoraproject.org |ed at eh3.com
Flag| |fedora-review?
--- Comment #1 from Ed Hill <ed at eh3.com> 2009-02-03 23:50:40 EDT ---
Hi Fabian,
Thank you for taking some time to package G3DViewer! Here is a quick
and somewhat incomplete review. I'll be happy to do a more thorough
review later this week.
good:
+ source matches upstream sha1sum:
26b4f0ea470b7572daf8d7773d2c00aa01f93058 libg3d-0.0.8.tar.gz
26b4f0ea470b7572daf8d7773d2c00aa01f93058 libg3d-0.0.8.tar.gz.1
+ naming OK
+ spec is legible
+ builds in mock for F10 x86_64
+ license is correctly included
+ use of ldconfig in post/postun looks OK
+ dir ownership looks OK
+ no *.la files
+ correct use of devel
+ has clean section
+ code not content
needswork:
- I think the license is LGPLv2+ not GPLv2+ -- please verify
- Please fix some of the grammatical errors in the description.
Here is a suggested replacement but please feel free to use
something else if you're not satisfied with it:
This library is typically used to load 3D model data from various file
formats. Its aim is to support basic import functionality for as many
formats as possible -- more file formats are planned. The library
provides numerous functions for basic 3D manipulation, vector/matrix
math, transformations, and 3D primitive support.
- rpmlint reports a number of rpath errors:
libg3d.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/g3d-stat
['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/image/img_dds.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/image/img_sgi.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/image/img_bmp.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_ac3d.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_nff.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_ar.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_cob.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_q3o.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_leocad.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_lwo.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_3ds.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_md3.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_vrml.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_ase.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_joe.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_glb.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_obj.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_3dmf.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_iob.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_heightfield.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_dxf.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_ldraw.so ['/usr/lib64']
libg3d-devel.x86_64: E: binary-or-shlib-defines-rpath
/usr/lib64/libg3d/plugins/import/imp_md2.so ['/usr/lib64']
4 packages and 0 specfiles checked; 24 errors, 0 warnings.
Please see http://fedoraproject.org/wiki/Packaging/Guidelines#Removing_Rpath
for some possible fixes.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list