[Bug 480851] Review Request: ccrypt - Secure encryption and decryption of files and streams

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=480851





--- Comment #3 from Gratien D'haese <gratien.dhaese at it3.be>  2009-02-04 09:21:04 EDT ---
(In reply to comment #2)
> 
> > Good.  Wondering if the following line is relevant for the description:
> > "which is the U.S. government's chosen candidate for the Advanced 
> > Encryption Standard." Your call.
> 
> I removed some sentences. 

Thanks - it is much better.

> 
> > Will you be able to fix the build problem on PPC? Otherwise, add a tag to
> > exclude it.
> > Via koji I was able to build on ppc.
> 
> I will exclude ppc64 for the moment.  This is my second package with issues
> about openssl on ppcX.

Thanks - acceptable for me.

> 
> > - MUST: All build dependencies must be listed in BuildRequires, except for any
> > that are listed in the exceptions section of the Packaging Guidelines ;
> > inclusion of those as BuildRequires is optional. Apply common sense.
> > 
> > You need the glibc-devel package for -lcrypt
> 
> I don't think that I need glibc-devel.  The koji log shows that the check for
> -lcrypt is ok without BR glibc-devel.  But maybe I'm mistaken...

Hum, is indeed strange, but your comment is correct. It works nice without it.
So, unless somebody complains do not use in the spec file.

> 
> http://koji.fedoraproject.org/koji/getfile?taskID=1100286&name=build.log
> 
> Updated files:
> 
> Spec URL: http://fab.fedorapeople.org/packages/SRPMS/ccrypt.spec
> SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/ccrypt-1.7-2.fc9.src.rpm
The SRPM URL was wrong! The correct URL is:
http://fab.fedorapeople.org/packages/SRPMS/ccrypt-1.7-2.fc10.src.rpm

Next actions are:
1/ final approval of the spec and RPM/SRPM packages of an "official" approver
is still needed
2/ finding a sponsor, but you did not need one according to your comment #2

Thanks, go ahead - for me it's fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.