[Bug 225856] Merge Review: gpm

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225856





--- Comment #12 from Robert Scheck <redhat-bugzilla at linuxnetz.de>  2009-02-04 16:42:16 EDT ---
Thank you for going on, rpmlint against latest CVS build (from http://
cvs.fedoraproject.org/viewvc/devel/gpm/gpm.spec?revision=1.69)

> gpm.x86_64: W: shared-lib-calls-exit /usr/lib64/libgpm.so.2.1.0 exit at GLIBC_2.2.5

Any ideas for this? That really looks strange to me - and I do not really
have a clue what causes this. See also below at the bottom of this comment.

> gpm.src: W: strange-permission gpm.init 0755
> gpm.x86_64: W: service-default-enabled /etc/rc.d/init.d/gpm
> gpm.x86_64: W: service-default-enabled /etc/rc.d/init.d/gpm
> gpm-devel.x86_64: W: no-documentation
> gpm-static.x86_64: W: no-documentation

Ignore so far. GPM should be enabled per default, otherwise the service does
not make so much sense to me. Docs are not available and permission can't be
solved after wrong import (as eplained above).

> %__cc %{?_smp_mflags} -o inputattach %{SOURCE2}

Well, we've lost $RPM_OPT_FLAGS. See build logs: %{?_smp_mflags} only causes
-jX, not the rest of the flags $RPM_OPT_FLAGS would bring. So please re-add.

Could you perform real integer comparisons rather half string comparisions?

-if [ "$1" = "0" ]; then
+if [ $1 -eq 0 ]; then

-if [ "$1" -ge "1" ]; then
+if [ $1 -ne 0 ]; then

Following is suggested to not break rpm transaction if something goes wrong:

-/sbin/install-info %{_infodir}/gpm.info.gz --delete %{_infodir}/dir
+/sbin/install-info %{_infodir}/gpm.info.gz --delete %{_infodir}/dir || :

Except of things raised above, I would say we're fine. Most hard seems to me
shared-lib-calls-exit - can we avoid it or can we just ignore the warning; I
had a look to bug #450011 and if I see correct, it depends on how it is done;
sometimes it can't be avoided. You know code better than me...suggestions?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.