[Bug 225711] Merge Review: dump

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225711





--- Comment #1 from manuel wolfshant <wolfy at nobugconsulting.ro>  2009-02-04 20:18:25 EDT ---
Created an attachment (id=330953)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=330953)
spec file patch - cleanups

Please find attached a small patch for the spec which makes rpmlint happier.
There are some errors left:
rpmlint of dump:
dump.x86_64: E: zero-length /etc/dumpdates
dump.x86_64: E: explicit-lib-dependency bzip2-libs
dump.x86_64: E: explicit-lib-dependency e2fsprogs-libs
dump.x86_64: E: explicit-lib-dependency libselinux
dump.x86_64: E: explicit-lib-dependency libsepol
dump.x86_64: E: explicit-lib-dependency zlib

I can understand the need of the zero-length dumpdates, but I do not understand
why does the spec say:
# This Requires is now mandatory because we only ship static binaries, and
# need to ensure the "disk" group is created before installation (#60461)
Requires: setup, e2fsprogs-libs, zlib, bzip2-libs, device-mapper
Requires: rmt, libselinux, libsepol, glibc

but later on you do:
  %configure --disable-static \

Of course rpmbuild picks all requires automatically, so I guess you should drop
either the explicit requires or the --disable-static.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.