[Bug 483857] Review Request: Eina - A classic player for a modern era

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483857





--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-02-05 10:24:45 EDT ---
You didn't paste rpmlint output. However it seems okay:
eina.i386: W: shared-lib-calls-exit /usr/lib/liblomo-1.0.so.1.0.0
exit at GLIBC_2.0
eina-devel.i386: W: no-documentation
3 packages and 1 specfiles checked; 0 errors, 2 warnings.

The spec file needs some work, however.

- The patch has no explanation. Why do you need it?

- Disable building static libraries with
%configure --disable-static

- After that, you may need to remove the .la files manually
http://fedoraproject.org/wiki/Packaging/Guidelines
and you can remove the %files sections relating .a and .la files.

- Package does not use Fedora optimization flags. Use
make %{?_smp_mflags} CFLAGS="%{optflags}"

- The desktop file has to be handled, see
http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

- %files section is *awfully* messy, I can't figure out what it says. Either
list all files, or use wildcards and a couple of excludes. Don't use %{dir}.

- Main package has a couple of .so files, these should be in -devel.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.