[Bug 484320] Review Request: perl-Lingua-Stem-Snowball - Perl interface to Snowball stemmers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484320


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-02-06 01:12:01 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1108450
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
6b0085c6fd8ec894e34c593078aa169a  Lingua-Stem-Snowball-0.952.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave 
All tests successful.
Files=6, Tests=10237,  4 wallclock secs ( 1.37 usr  0.05 sys +  3.92 cusr  0.05 
+ Package  perl-Lingua-Stem-Snowball-0.952-1.fc11 =>
  Provides: Snowball.so perl(Lingua::Stem::Snowball) = 0.952
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1.3) perl >=
0:5.006002  perl(Carp) perl(DynaLoader) perl(Exporter) perl(strict) perl(vars)
perl(warnings) rtld(GNU_HASH)

Suggestions:
1) remove following line from SPEC
Requires:       perl(Test::More)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.