[Bug 483301] Review Request: muse - Midi/Audio Music Sequencer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483301


Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #2 from Ralf Corsepius <rc040203 at freenet.de>  2009-02-08 04:06:28 EDT ---
Some comments:

MUSTFIX:
* AutoReqProv:   no
This disables rpm's automatic dependency tracking and therefore is strongly
frowned upon.

* Epoch: 1
Setting epoch to != 0 for a package to be included into Fedora is hardly
useful.

SHOULD:
* Building on x86_64 emits serious warning, e.g. this

memory.h: In member function 'void* Pool::alloc(size_t)':
memory.h:55: warning: format '%d' expects type 'int', but argument 2 has type
'size_t'
memory.h: In member function 'void Pool::free(void*, size_t)':
memory.h:73: warning: format '%d' expects type 'int', but argument 2 has type
'size_t'

In many cases, this kind of warnings are the origin of mal-functions.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.