[Bug 484386] Review Request: gri - A language for scientific illustration

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484386


Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jussi.lehtola at iki.fi




--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-02-08 06:17:32 EDT ---
Just a few comments:

- License is GPLv2+, not GPLv2.

- Remove Requires: readline, this is automatically picked up.

- Remove pushd and popd from setup, you don't need them.

- Change make command to
make %{?_smp_mflags}
as this works fine. The paths are already set by %configure.

- Replace "rm -Rf" with "rm -rf" to be consistent.

- Absolute paths in %files need to be replaced with %{_bindir}, %{_datadir} and
so on.

- Changelog is way too long, IMHO you may remove everything that is before
2006.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.