[Bug 480887] Review Request: kguitar - Guitar Tabulature Music Editor
bugzilla at redhat.com
bugzilla at redhat.com
Sun Feb 8 16:45:48 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=480887
Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
AssignedTo|nobody at fedoraproject.org |mtasaka at ioa.s.u-tokyo.ac.jp
Flag| |fedora-review?
--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> 2009-02-08 11:45:46 EDT ---
Ah, after reading http://musicxml.org/xml.html and
also this:
https://bugzilla.redhat.com/show_bug.cgi?id=357461
and also your explanation:
- This MusicXML document format license is free, GPL imcompatible
- However it seems that kguitar behaves just an interpreter or
editor for MusicXML document format license files.
So there should no license issue for this package. Then:
* _texmf macro
- Isn't the following enough?
-------------------------------------------------------------
%{!?_texmf: %define _texmf %(kpsewhich -expand-var '$TEXMFMAIN')}
-------------------------------------------------------------
! Versioning
- For svn based tarball, I prefer to include revision number
rather than the date I pulled the source because revision
number specifies the source used precisely, however
this is left to your choice.
- By the way, would you tell me if this is after or before
0.5.1 formal release?
* TeX dependency
- I think 30 Mbyte extra dependency is enough large.
Also I think that requiring another font for this package
should not be mandatory.
TeX related dependency should be split out.
I would choose "kguitar-tex" for TeX related subpackage.
* Timestamps
-------------------------------------------------------------
touch -r %{name}/x-%{name}.desktop tmpfile
-------------------------------------------------------------
- Is it really needed here to keep timestamps on this file?
You "actually" modified this desktop file here.
? Desktop file location
- Is it needed that the desktop file is installed under
%_datadir/applications/kde, not under %_datadir/applications?
Such desktop files cannot be seem from GNOME, however
it seems that this application can be used also on GNOME.
* _docdir
- Files/directories under %_docdir are automatically marked
as %doc
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list