[Bug 484535] Review Request: kde-plasma-networkmanagement - Plasmoid to control Network Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484535


Milos Jakubicek <xjakub at fi.muni.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED




--- Comment #9 from Milos Jakubicek <xjakub at fi.muni.cz>  2009-02-08 20:04:20 EDT ---
- regarding the rpmlint output, as discussed in previous comments -- please
fix:
kde-plasma-networkmanagement.src:25: W: unversioned-explicit-obsoletes
kde-plasma-networkmanagement.x86_64: W: obsolete-not-provided
kde-plasma-networkmanagement.x86_64: W: no-documentation
(include the TODO and DESIGN file)

- use macros in %build and %files:
%{cmake_kde4} .. -DDBUS_SYSTEM_POLICY_DIR=/etc/dbus-1/system.d
/etc/dbus-1/system.d/NetworkManager-kde4.conf

/etc => %{_sysconfdir}

- remove unnecessary BR (main package) and R (for -devel subpackage):
  BR/R: NetworkManager-devel which is required by NetworkManager-glib-devel
  BR/R: kdelibs4-devel which is required by kdebase-workspace-devel

  Requires(post): /sbin/ldconfig xdg-utils
  Requires(postun): /sbin/ldconfig xdg-utils
  (Those are taken by rpm automagically)

- please provide a more appropriate description than %{summary} for the main
package.

- please provide a less general URL than just kde.org, e.g.
http://websvn.kde.org/trunk/playground/base/plasma/applets/networkmanager/

- there is no licensing info besides the qt dual license and .desktop files;
nor in an attached LICENSE file, nor in the source files -- that's bad. Please
ask upstream to include a license file and to mention the license in the
sources.
You should also include a LICENSE.GPL and GPL_EXCEPTION.txt file as the qt
license states.

- please fix the gcc flags, something like this before the make call should be
enough:

find . -name "flags.make" -execdir sed -i -e 's/-fno-exceptions -fno-check-new
-fno-common//' -e 's/-fno-threadsafe-statics -fvisibility=hidden
-fvisibility-inlines-hidden//' -e 's/-ansi//' {} \;

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.