[Bug 484323] Review Request: perl-KinoSearch - Search engine library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484323


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |182235




--- Comment #2 from Lubomir Rintel <lkundrak at v3.sk>  2009-02-09 10:23:38 EDT ---
0.) This is redundant:
Requires:       perl(Compress::Zlib)
It gets added by the auroreq generator.

1.) rpmlint:

perl-KinoSearch.i386: E: zero-length
/usr/lib/perl5/vendor_perl/5.8.8/i386-linux-thread-multi/auto/KinoSearch/KinoSearch.bs

2.) License:

I'm worried about this, and am blocking the review until it is solved. The
perldoc reads:

       Terms of usage for Apache Lucene, from which portions of KinoSearch are
derived, are spelled out in the Apache License: see the file
"ApacheLicense2.0.txt".

While the original code is licensed "GPL+ or Artistic". If my understanding of
things is correct, we can't choose "GPL" since it does not permit
redistribution when linked with ASL code and we can't choose Artistic either,
since it's incompatible with Fedora. I think a clarification and eventually and
addition of exception to allow linking with ASL from upstream would be good
here.

IANAL, I might be completely wrong. Adding spot to CC, he may provide valuable
advice.

In other respects, the package is perfect:
- SPEC file clean and legible
- Builds in mock, obeys compiler flags
- rpmlint is mostly quiet (see 1.)
- requires/provides (mostly, see 0.) sane
- ASL license 2.0 text included (heh...)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.