[Bug 226493] Merge Review: tix

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226493





--- Comment #5 from Vitezslav Crhonek <vcrhonek at redhat.com>  2009-02-09 10:28:47 EDT ---
(In reply to comment #4)
> I would like to take this review. My interest in tix comes from the python side
> and it is always nice to have one more merge review finished. :-)
Thanks for taking it.

> 
> I noticed the open review since comment #3 but I have been busy meanwhile.
> Sorry. :-)
> 
> The first standard question regarding this issue is the output of rpmlint over
> the produced rpms:
> 
> tix.i686: W: non-conffile-in-etc /etc/ld.so.conf.d/tix-i386.conf
As you said, this is OK (it's not real config file).

> tix.i686: E: script-without-shebang /usr/lib/tcl8.5/Tix8.4.3/pref/WmDefault.tcl
Hm, WmDefault.tcl is used as module if I understand it correctly, so missing
shebang is OK, but it's probably also OK to remove executable permission... But
I don't know much about it (only what's written in WmDefault.txt), so what do
you think?

> tix.src: W: patch-not-applied Patch1: tix-8.4.2-tcl8.5.patch
> tix-doc.i686: W: spurious-executable-perm
Fixed.

> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/tlist/twofont.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/container/notebook.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/intro/combo.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/intro/hierarchy.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/filesel/dirlist.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/tlist/relation.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/hlist/dirtree.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/container/sl-bar.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/filesel/exfile.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/oop/arrows.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/intro/select1.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/container/pane_vert.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/tlist/widgets.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/intro/law_comp.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/hlist/hlist_ex3.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/tlist/tlist.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/tix32.png
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/container/sl-nobar.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/ARROWS.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/hlist/hlist_ex1.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/hierarchy.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/container/pane_horz.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/filesel/dirtree.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/intro/lawyer.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/tlist/horizontal.gif
Fixed.

> tix-doc.i686: W: wrong-file-end-of-line-encoding
> /usr/share/doc/tix-doc-8.4.3/Release-8.4.0.txt
Fixed.

> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/filesel/fb_comp.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/intro/ctl_wopt.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/intro/select-vert.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/hlist/hlist_ex2.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/tlist/joe.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/hierarchy.png
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/intro/ctl_subw.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/container/pane_add.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/tlist/vertical.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/tix32.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/tlist/twofont2.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/intro/select.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/arrows.png
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/hlist/hlist1.gif
> tix-doc.i686: W: spurious-executable-perm
> /usr/share/doc/tix-doc-8.4.3/html/gif/tix/intro/ctl_noopt.gif
Fixed.

> 
> Note that I am quite aware that some of the those warnings are bogus, with the
> firts one being too obvious. :-)
> 
> Nevertheless I would like to hear about the others.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.