[Bug 484591] Review Request: muse - Midi/Audio Music Sequencer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484591


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #5 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-02-10 03:54:18 EDT ---
(Note that I mailed to Orcan privately...)

(In reply to comment #3)
> The correct solution here is
> to use filtering of the generated provides as explained in the previous review
> request.
- As Kevin said in the comment 4 (and as I reported on the bug
  484837), the filtering method proposed on the previous review request
  is not correct on x86_64


(In reply to comment #4)
> Oops, the solution I provided for filtering is faulty, see:
> https://bugzilla.redhat.com/show_bug.cgi?id=484837
> 
> %{__sed} '/\.so$/d' needs to be: %{__sed} '/\.so\(()(64bit)\)\?$/d'
- This time it is not correct on i386.

> Also the warnings are serious and need fixing, Ralf has already explained how
> (replace "%d" with "%zd"), let me know if there are other warnings which you
> need help fixing.

- Would you explain why you "particularly" mention these warnings?
  These warnings all comes from (f)printf with passing incorrect format,
  however I have already seen in other review requests that
  many warnings which seemed more and more critical than this
  (like one related to implicit function declaration you mentioned
   before) were just ignored.
  Of course I admit that fixing these warnings are desirable, however
  I am against making these warning the "blocker" for this review
  request.
  If you surely think these warnings are blockers, would you propose
  fedora-packaging-list about what warnings should be treated as
  review blockers? 
  It is really appreciated because I had repeatedly been asked
  "is it a blocker??"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.