[Bug 483205] Review Request: eclipse-systemtapgui - GUI interface for SystemTap

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483205





--- Comment #24 from Anithra <anithra at linux.vnet.ibm.com>  2009-02-10 04:25:58 EDT ---
(In reply to comment #23)
> X BuildRequires are proper
>  - do we need a BR/R on SystemTap itself?  What about kernel-devel?
We wont need it as this can run on machines without systemtap(even on
windows.). The probes and functions wont be listed in the IDE but apart from
that it should work fine as the script is sent to the server for execution.
> X make sure lines are <= 80 characters
>  - please wrap line 29 (the pdebuild call) with '\' characters
done.
> ? macros fine
>  - it would be nice if you s/$RPM_BUILD_ROOT/%{buildroot}/ but it's not the
>    end of the world
done.

SPEC URL:
http://nchc.dl.sourceforge.net/sourceforge/stapgui/eclipse-systemtapgui.spec
SRPM URL:
http://downloads.sourceforge.net/stapgui/eclipse-systemtapgui-1.0-5.fc11.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.