[Bug 484591] Review Request: muse - Midi/Audio Music Sequencer

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 10 09:50:21 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484591


Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #8 from Ralf Corsepius <rc040203 at freenet.de>  2009-02-10 04:50:19 EDT ---
(In reply to comment #6)

> As Ralf has demonstrated these warnings are usually a real issue, which only
> shows on 64 bit systems. But usually these are in debug printf's and thus quite
> often people don't care about fixing them. I agree this is not something which
> we normally block reviews on. So I wont do that in this case either. Still this
> something which really should be fixed, so consider this a should fix item.

That's why I had labeled it "SHOULD".

It's a classic of the 32bit->64bit portability problems.

It is broken code which is guaranteed to be non-functional under certain
conditions. The only question is when this bug will hit, not if this will this
will hit.

Due to the nature of size_t, such kind of bugs show when some variable will
exceed sizeof(int) (4GB) or when some computations will be performed on
size_t's.

The former will usually only cause visible problems in "big use-cases", while
the later usually shows as "corrupt output".

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list