[Bug 483615] Review Request: CodeAnalyst - Performance Analysis Suite for AMD-based System (based on Oprofile)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483615





--- Comment #5 from Parag AN(पराग) <panemade at gmail.com>  2009-02-12 05:52:04 EDT ---
1)Avoid use of hash in spec file it looks complicated to me.
2)desktop file should be installed using desktop-file-install command
remove desktop-file-validate command lines in SPEC

3) .so files must go to separate -devel subpackage. See 
http://fedoraproject.org/wiki/PackagingGuidelines#Devel_Packages

4) buildroot value not as per given at
http://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag

5) any reason to change tarball name from CodeAnalyst to 
CodeAnalyst-gui?

6)You need to use any value from $RPM_OPT_FLAGS %{optflags} not both see
http://fedoraproject.org/wiki/PackagingGuidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

7) When I fix above problems locally on my machine and built rpm, I used
rpmlint on binary package where I see some messages related to init script
reported as
rpmlint -iv /usr/src/redhat/RPMS/i386/CodeAnalyst-gui-2.8.38-0.fc10.i386.rpm

CodeAnalyst-gui.i386: W: service-default-enabled
/etc/rc.d/init.d/codeanalyst_init
===>The service is enabled by default after "chkconfig --add"; for security
reasons, most services should not be. Use "-" as the default runlevel in the
init script's "chkconfig:" line and/or remove the "Default-Start:" LSB keyword
to fix this if appropriate for this service.

CodeAnalyst-gui.i386: E: subsys-not-used /etc/rc.d/init.d/codeanalyst_init
===>While your daemon is running, you have to put a lock file in
/var/lock/subsys/. To see an example, look at this directory on your machine
and examine the corresponding init scripts.

CodeAnalyst-gui.i386: W: incoherent-init-script-name codeanalyst_init
==>The init script name should be the same as the package name in lower case,
or
one with 'd' appended if it invokes a process by that name.

8)Every time you change in SPEC update Release to next number e.g. now you
should change it to 1. Add changelog what you changed in SPEC for this -1
release
Then submit this new package for further review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.