[Bug 484726] Review Request: impressive - The stylish way of giving presentations

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484726





--- Comment #3 from Jochen Schmitt <jochen at herr-schmitt.de>  2009-02-12 12:03:30 EDT ---
Good:
+ License tag contains the correct entry GPLv2
+ Package contains empty %build stanza with comment

Bad.
- You should a deja-sans-fonts as a Req.(Please koop in mind, that the
packagename was change from F-10 to F-11)
- I see no effort to create a wrapper script using the opengl-wrapper
script.Please us something like this:

#!/bin/bash

. /usr/share/opengl-games-utils/opengl-game-functions.sh

GAME=`basename $0 | sed 's/-wrapper.*//'`

checkDriOK $GAME

exec $GAME "$@"

as an template for your own efforts

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.