[Bug 485424] Review Request: eclipse-birt - Eclipse-based reporting system

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485424





--- Comment #2 from Alexander Kurtakov <akurtako at redhat.com>  2009-02-13 12:15:06 EDT ---
Spec URL:
http://akurtakov.fedorapeople.org/eclipse-birt.spec
SRPM URL:
http://akurtakov.fedorapeople.org/eclipse-birt-2.3.1-2.fc10.src.rpm


(In reply to comment #1)
> - please add a comment stating why we're only building the feature we are
Fixed. It was already done but more details added.
> - please add information about steps to get us to a full BIRT here: 
> http://fedoraproject.org/wiki/Eclipse
Fixed. Same as previous.
> - please add a comment above the one patch stating why we're doing this
Fixed.
> - let's change the variable "qualifier" to "rhinoqualifier" to avoid confusion
Fixed.
> - should we be using the same qualifier as BIRT like we do with Mylyn?
No. Different BIRT plugins hava different qualifiers so it's not applicable.
> 
> Lines beginning with X need attention; those beginning with * are okay:
> 
> * verify the final provides and requires of the binary RPMs
> X make sure lines are <= 80 characters
>   - please add some line continuations to fix this where possible
Fixed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.