[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607





--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-02-15 05:31:43 EDT ---
- Name should be scitools, not SciTools.
 * You need to change also "setup -q" to "setup -q -n SciTools-%{version}"

- Double Requires: gnuplot, remove the latter one.

- Missing BuildRequires: python-devel

- Missing python_sitelib macro, see
http://fedoraproject.org/wiki/Packaging/Python

- Install section should be
%install
rm -rf $RPM_BUILD_ROOT
%{__python} setup.py install --root $RPM_BUILD_ROOT

- Files should be
%{python_sitelib}/*egg-info
%{python_sitelib}/%{name}
instead of
%{_libdir}/*

as the latter version would own system directories, and doesn't work on 64-bit
architectures.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.