[Bug 478506] Review Request: trac-customfieldsadmin-plugin - expose ticket custom fields via web admin interface

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478506


Ian Weller <ianweller at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #8 from Ian Weller <ianweller at gmail.com>  2009-02-15 15:26:51 EDT ---
== FULL REVIEW ==

[  OK  ] specfiles match:
  fcb61fc7a2957865ab2b3e0f135eb732  trac-customfieldadmin-plugin.spec
  fcb61fc7a2957865ab2b3e0f135eb732  trac-customfieldadmin-plugin.spec.1
[FAILED] source files match upstream:
  I can't tell. The instructions included in the specfile to generate the
  tarball don't work.
  svn: '/svn/!svn/bc/5267/customfieldsadminplugin/0.10' path not found
[  OK  ] package meets naming and versioning guidelines.
[  OK  ] spec is properly named, cleanly written, and uses macros consistently.
[  OK  ] dist tag is present.
[  OK  ] build root is correct.
[  OK  ] license field matches the actual license.
[  OK  ] license is open source-compatible.
[  OK  ] license text included in package.
[  OK  ] latest version is being packaged.
[  OK  ] BuildRequires are proper.
[  N/A ] compiler flags are appropriate.
[  OK  ] %clean is present. 
[  OK  ] package builds in mock.
[  OK  ] package installs properly.
[      ] debuginfo package looks complete.
[  OK  ] rpmlint is silent.
  It did return:
   trac-customfieldadmin-plugin.noarch: W: no-documentation
   trac-customfieldadmin-plugin.noarch: E: script-without-shebang
/usr/lib/python2.5/site-packages/customfieldadmin/htdocs/js/CustomFieldAdminPage_actions.js
  but seeing how it didn't come with documentation and that Javascript files 
  don't have shebangs, I'd ignore it.
[  OK  ] final provides and requires are sane
[  N/A ] %check is present and all tests pass:
[  N/A ] no shared libraries are added to the regular linker search paths.
[  OK  ] owns the directories it creates. 
[  OK  ] doesn't own any directories it shouldn't.
[  OK  ] no duplicates in %files.
[  OK  ] file permissions are appropriate.
[  N/A ] scriptlets match those on ScriptletSnippets page.
[  OK  ] code, not content.
[  OK  ] documentation is small, so no -docs subpackage is necessary.
[  OK  ] %docs are not necessary for the proper functioning of the package.
[  OK  ] no headers.
[  OK  ] no pkgconfig files.
[  OK  ] no libtool .la droppings.
[  OK  ] desktop files valid and installed properly.

 -------------------------------------------------------
  I approve this package (trac-customfieldadmin-plugin)
 -------------------------------------------------------
  (just be sure to check on the SVN instructions)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.