[Bug 485643] Review Request: django-authopenid - Django application to integrate Django authentication system with OpenID

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485643


Peter Lemenkov <lemenkov at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #2 from Peter Lemenkov <lemenkov at gmail.com>  2009-02-16 06:39:28 EDT ---
REVIEW:

+ rpmlint is silent:

[petro at host-12-116 Desktop]$ rpmlint django-authopenid-0.9.6-1.fc10.*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
[petro at host-12-116 Desktop]$

+ I'm in doubts about package naming - Django packages in Fedora are named with
first letter capitalized. However the upstream named it with all letters in
lowercase, so I don't think this is a problem at all.
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The file with text of the license, is be included in %doc.
+ The spec file is be written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source, as
provided in the spec URL.

[petro at Sulaco SOURCES]$ md5sum django-authopenid-0.9.6.tar.gz*
b15d22dd9d83a5c5fa8a0a640b40b3f4  django-authopenid-0.9.6.tar.gz
b15d22dd9d83a5c5fa8a0a640b40b3f4  django-authopenid-0.9.6.tar.gz.from_srpm
[petro at Sulaco SOURCES]$ 

+ The package MUST successfully compiles and builds into binary rpms on at
least one primary architecture.

http://koji.fedoraproject.org/koji/taskinfo?taskID=1129812

+ All build dependencies are listed in BuildRequires.
+ The package owns all directories that it creates.
+ The package does not contain any duplicate files in the %files listing.
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package contains code, or permissable content.
+ Everything, that the package includes as %doc, does not affect the runtime of
the application.
+ The package does not own files or directories already owned by other
packages. 
+  At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in the package are valid UTF-8. [26]


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.