[Bug 485636] Review Request: cutecom - A GUI application for serial port communications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485636





--- Comment #1 from manuel wolfshant <wolfy at nobugconsulting.ro>  2009-02-16 14:23:30 EDT ---
What is the reason of using
 # Upstream script does not install the .desktop file if KDE is not installed, 
 # so we install it manually:
 install -D -m 644 $(pwd)/cutecom.desktop
${RPM_BUILD_ROOT}%{_datadir}/applications/cutecom.desktop 
 # Validate .desktop files:
 desktop-file-validate
${RPM_BUILD_ROOT}%{_datadir}/applications/cutecom.desktop

instead of desktop-file-install which install and validates in a sigle step ?


According to the source files, the license should be GPLv2+. All of them
include:
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
    the Free Software Foundation; either version 2 of the License, or
    (at your option) any later version.

You must include the license (COPYING) as %doc. I would also include the
changelog and the "todo" files but I wouldn't cry if you choose to ignore them.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.