[Bug 485607] Review Request: SciTools - A Python library for scientific computing

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485607





--- Comment #21 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-02-16 17:20:25 EDT ---
- Hmm, so README.bin is a new file? Don't supply it as a patch, then, just make
it another source.

Also, as the file is related to the Fedora package, it should be named
README.Fedora as a distinction to other files that have been provided by
upstream.


- "- Moved _bindir to documentation" is sloppy: the system binary directory has
not been moved! The entry should be something like: "- Moved files from
%%{_bindir} to documentation to prevent clashes." Note the double %% to prevent
rpmbuild from expanding the macro in the changelog.


- Your release numbering is a bit unconventional, normally releases are
numbered starting from 1 and with integers, not decimals.


- Also, please run rpmlint on the releases you create (both SRPM/spec file and
compiled binary RPMS including the debuginfo packages), and paste the output in
the bugzilla entry (here). This helps both you and the reviewer.

I will try to do the review tomorrow.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.