[Bug 484933] Review Request: libwps - Library for reading and converting Microsoft Works word processor documents

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484933





--- Comment #14 from Michael Schwendt <bugs.michael at gmx.net>  2009-02-17 06:26:41 EDT ---
Nothing in the guidelines, so:

In %install I would fix the permissions of the installed documentation files
(chmod -x) in the buildroot, remove the INSTALL file, and use this:

  %files doc
  %defattr(-,root,root,-)
  %_docdir/%{name}-%{version}/html/

and in the main pkg:

  %_docdir/%{name}-%{version}/
  %exclude %_docdir/%{name}-%{version}/html/

Of course, you can distribute the files to subpkgs even further, but why? All
documentation is in the same doc rootdir, which is fine as it is.

The -doc package is just 168 KB and 1.7 MB extracted. It would not even hurt
much if you included the html tree in the -devel pkg instead. A matter of
taste.

[...]

On the contrary, your current spec file creates four different docdirs:

  /usr/share/doc/libwps-0.1.2/
  /usr/share/doc/libwps-devel-0.1.2/
  /usr/share/doc/libwps-doc.0.1.2/
  /usr/share/doc/libwps-tools-0.1.2/

with -tools and -devel only containing a single file, and with the API docs not
in -devel, but in the -doc dir.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.