[Bug 459444] Review Request: ctdb - Clustered TDB

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459444


Jeremy Katz <katzj at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |katzj at redhat.com




--- Comment #23 from Jeremy Katz <katzj at redhat.com>  2009-02-17 10:33:38 EDT ---
Okay, picking up the review, there are still some things that aren't quite
right here

There are two that are definitely blockers
* What is the canonical upstream location?  The repo mentioned on
http://ctdb.samba.org/download.html doesn't have the version being packaged or
the included COPYING file.  
* In the %postun, you should be doing condrestart, not restart -- otherwise, an
upgrade will end up always starting ctdb for people.  


These are smaller things, but really should be fixed also
* If your source is really just a git archive, please follow the guidelines for
those
(https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control) as
opposed to a one-off directory which isn't keeping old versions of the tarballs
* Rather than copying docs into docdir directly, you can just list them with
    %doc COPYING
    %doc doc/ctdb
or similar in the %files section -- note that these paths are then relative to
the source dir
* There still needs to be a comment for the patches
* Why is /etc/ctdb/statd-callout in /etc?  General purpose scripts generally
shouldn't be in /etc
* Is the build process not safe for make -j?  


And the final thing, who is actually intending to own this package now and is a
sponsor still needed?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.