[Bug 483205] Review Request: eclipse-systemtapgui - GUI interface for SystemTap

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483205





--- Comment #30 from William Cohen <wcohen at redhat.com>  2009-02-17 10:44:16 EDT ---
I built the package locally on F-10 and F-11. I looked through the output of
the build and saw a number of messages about generic types should be
parameterized and "Discouraged access" like the following examples:

    [javac] ----------
    [javac] 1. WARNING in
/home/wcohen/rh-rpms/BUILD/eclipse-systemtapgui-1.0/bu
ild/plugins/com.ibm.systemtapgui.generic.editor/src/com/ibm/systemtapgui/generic
/editor/ColorManager.java (at line 29)
    [javac]  Iterator e = fColorTable.values().iterator();
    [javac]  ^^^^^^^^
    [javac] Iterator is a raw type. References to generic type Iterator<E>
shoul
d be parameterized


    [javac] ----------
    [javac] 13. WARNING in
/home/wcohen/rh-rpms/BUILD/eclipse-systemtapgui-1.0/b
uild/plugins/com.ibm.systemtapgui.generic.consolelog/src/com/ibm/systemtapgui/ge
neric/consolelog/actions/ConsoleAction.java (at line 77)
    [javac]  private boolean isRunning(ConsoleView cv) {
    [javac]                            ^^^^^^^^^^^
    [javac] Discouraged access: The type ConsoleView is not accessible due to
re
striction on classpath entry
/home/wcohen/rh-rpms/BUILD/eclipse-systemtapgui-1.0
/build/SDK/plugins/org.eclipse.ui.console_3.3.0.v20080529-1300.jar

Are these warnings something that should be cleaned up? Or can they be safely
ignored?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.