[Bug 485416] Review Request: msp430-gcc - Cross compiling GNU GCC for the MSP430

bugzilla at redhat.com bugzilla at redhat.com
Tue Feb 17 16:10:33 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485416


Ralf Corsepius <rc040203 at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203 at freenet.de




--- Comment #6 from Ralf Corsepius <rc040203 at freenet.de>  2009-02-17 11:10:32 EDT ---
(In reply to comment #1)
> Created an attachment (id=331830)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=331830) [details]
> koji ppc64 build.log ending in failure.
> 
> As documented in specfile, build fails in koji for ppc64.  I attach the
> build.log for this failure.
This build fails, because you are not correctly passing CFLAGS to configure.

You need to override CC in configure
CC="%{__cc} ${RPM_OPT_FLAGS}" ./configure

Then it builds: http://koji.fedoraproject.org/koji/taskinfo?taskID=1133315

Other issues:
* MUSTFIX: Your package must own %{_libdir}/gcc-lib

* CONSIDER: The libexecdir warnings you observe, originate from this antiquated
GCC not to install anything to below %_libexecdir.
(Newer gcc's install internal binaries to %_libexecdir/gcc/<target>/<version>,
ancient GCCs install them to %{_libdir}/gcc-lib/<target>/<version> and mix them
up with target binaries)
=> the whole debug_info/brp-strip hacks are non-functional in this case.

You have 2 alternatives to address this:
a) Fix the sed call to hack up brp-strip in such a way it only picks up the
host-executables

b) Remove all the hack entirely and live with the warnings brp-strip issues
However, you seem to be lucky, this seems possible in this case, because
brp-strip etc. (at least on Fedora 10) are broken enough not to try corrupting
your target's files.


* CONSIDER: I would change your %prep/%setup into
%prep
%setup -q -T -c
%setup -q -T -D -a0
%setup -q -T -D -a1
(But that's just my personal preference.)

* CONSIDER: Instead of removing the *.1's you could rename them into
%{target}-*.1
(A bug having been fixed in upstream GCCs for several years).


Finally, I guess you know that gcc-3.2.3 is dead and discontinued for ca.
5 years - Not actually something I would want to maintain ;-)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list