[Bug 485954] Review Request: Marlin, A Sound Sample Editor for GNOME.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485954





--- Comment #2 from Joseph Smidt <jsmidt at fedoraproject.org>  2009-02-18 01:01:29 EDT ---
Initailly a lot looks good.

A couple issues:

1. Please be consistant with macros.  In some places you use $RPM_BUILD_ROOT,
in others %{buildroot}.

2. There is a Requires(pre) but no %pre section.

3. https://fedoraproject.org/wiki/Packaging/ScriptletSnippets says scrollkeeper
should look like this: 

%post
scrollkeeper-update -q -o %{_datadir}/omf/%{name} || :

%postun
scrollkeeper-update -q || :

And like this for update-desktop-database:

%post
update-desktop-database &> /dev/null || :

%postun
update-desktop-database &> /dev/null || :

Also, you need to add:
Requires(post): desktop-file-utils
Requires(postun): desktop-file-utils

4. Remember to post your output for rpmlint.

Great work so far.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.