[Bug 473583] Review Request: WordNet - A lexical database for the english language

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473583


Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tcallawa at redhat.com
               Flag|                            |fedora-review?




--- Comment #10 from Tom "spot" Callaway <tcallawa at redhat.com>  2009-02-18 14:07:59 EDT ---
Two issues here:

1. please use %{_datadir} instead of /usr/share.
2. These files shouldn't be in the package. 
/usr/share/wordnet-3.0/include/tk
/usr/share/wordnet-3.0/include/tk/tk.h
/usr/share/wordnet-3.0/include/tk/tkDecls.h

In fact, upstream really shouldn't be shipping these files as part of wordnet,
they should rely on the system tk-devel (they're using the system libtk, but
providing mismatched tk headers?).

I'll attach a patch to remove it from the Fedora package. You'd need to apply
this patch and also delete the include/tk dir in %prep.

Show me a fixed package and I'll finish this review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.