[Bug 485954] Review Request: Marlin, A Sound Sample Editor for GNOME.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485954


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #4 from Fabian Affolter <fabian at bernewireless.net>  2009-02-19 03:45:30 EDT ---
Some other quick comments on your spec file

- '--vendor fedora' is obsolete
  https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files
- Isn't 'BuildRequires: gettext' (for translation) and 'Requires:
hicolor-icon-theme' (for icons) missing?
- Unversioned shared libraries should go into a -devel subpackage
  https://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages
- Take a look at
https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#desktop-database
about 'Requires(post)/(postun): desktop-file-utils'

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.