[Bug 485636] Review Request: cutecom - A GUI application for serial port communications

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485636


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #6 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-02-20 11:42:38 EDT ---
Looks good. Some comments.

- Would you split a long command line into several lines like below
  so that we can read it easier line below?
----------------------------------------------------------------
desktop-file-install \
   --remove-key=Path --remove-key=Encoding \
   --removekey=BinaryPattern --remove-key=TerminalOptions \
   --add-category=System \
   --dir ${RPM_BUILD_ROOT}%{_datadir}/applications/ \
   $(pwd)/cutecom.desktop
----------------------------------------------------------------

(In reply to comment #5)
> The only remaining detail is the icon, but I'm
> not sure on whether it can be changed via desktop-file-install, or I should
> modify it "manually" (via 'sed', etc...) from the script.

- You can just use sed (at %prep)

------------------------------------------------------------
  This package (cutecom) is APPROVED by mtasaka
------------------------------------------------------------

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.