[Bug 224245] Merge Review: squirrelmail

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=224245


Jason Tibbitts <tibbs at math.uh.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |tibbs at math.uh.edu
               Flag|                            |fedora-review?




--- Comment #21 from Jason Tibbitts <tibbs at math.uh.edu>  2009-02-21 14:14:44 EDT ---
This package looks quite a bit better now.

Regarding the stuff in the demo directory, I think any of those possibilities
would work, although a subpackage is probably overkill.

Regarding the patches, it would be nice to document them somehow (at least
adding comments to the spec referring to the above bugzilla tickets) but I'm
not really sure it's within the scope of this review to insist that those
remaining three patches be reconciled with upstream.  It would certainly be a
good idea to work with upstream to somehow make them unnecessary, and of course
Fedora is steadfastly against letting more of this kind of thing creep in (see
http://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment,
 and http://fedoraproject.org/wiki/PackageMaintainers/WhyUpstream) but I
recognize that there is some historical cruft that may not be simple to get rid
of.

So really I'd say that if those patches were documented in the spec with links
to the above bugzilla tickets, and something is done with the demo directory
then I would consider the package OK.  I would still urge further work with
upstream and perhaps the previous maintainers of this package to understand the
patches and either get them sent upstream or dropped from the package.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.