[Bug 486558] Review Request: mono-nat - .NET library for automatic port forwarding

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486558


Paul Lange <palango at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|palango at gmx.de              |gnomeuser at gmail.com
               Flag|fedora-review?              |fedora-review+




--- Comment #4 from Paul Lange <palango at gmx.de>  2009-02-21 17:17:32 EDT ---
Don't know where I found this Readme file. Most probably it only exists in my
brain or in mono-torrent. forget about it ;)

Further (more formal) review:
- MUST: rpmlint must be run on every package. The output should be posted
in the review.
mono-nat.i386: W: no-documentation
We can't change this, maybe we could ask upstream.
mono-nat.i386: E: no-binary
mono-nat.i386: E: only-non-binary-in-usr-lib
Can be ignored.
mono-nat-devel.i386: W: no-documentation
We can't change this.

- MUST: The package must be named according to the Package Naming Guidelines
OK

- MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec
OK

- MUST: The package must meet the Packaging Guidelines.
OK

- MUST: The package must be licensed with a Fedora approved license and meet
the  Licensing Guidelines .
OK

- MUST: The License field in the package spec file must match the actual
license.
OK

- MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.
License file not included.

- MUST: The spec file must be written in American English.
OK

- MUST: The spec file for the package MUST be legible.
OK

- MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
OK

- MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.
OK

- MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line.
Currently handled with "ExclusiveArch:". Maybe change this to
"ExcludeArch:ppc64"?

- MUST: All build dependencies must be listed in BuildRequires, except for any
that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.
OK

- MUST: A package must not contain any duplicate files in the %files listing.
OK

- MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line.
OK

- MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT).
OK

- MUST: Each package must consistently use macros.
OK

- MUST: The package must contain code, or permissable content.
OK

- MUST: Header files must be in a -devel package.
OK

- MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability).
OK

- MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
OK

- MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time.
OK

- MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT).
OK

- MUST: All filenames in rpm packages must be valid UTF-8.
OK

############################################################

So the only thing I can find is the ExclusiveArch vs. ExcludeArch problem. I
think booth works, maybe we should create a default for Mono Packages.

The text update could be done later. I also assigned the bug to you.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.