[Bug 484507] Review Request: php-channel-ezc - eZ Components

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484507


Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |fedora at famillecollet.com
               Flag|                            |fedora-review+




--- Comment #1 from Remi Collet <fedora at famillecollet.com>  2009-02-22 02:44:34 EDT ---
REVIEW
* no source files
* package meets naming and packaging guidelines (recently approved new PHP
Guidelines).
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license (of the packages provided by the
channel).
* license is open source-compatible (BSD).
* BuildRequires are proper.
* %clean is present.
* package builds in mock (rawhide).
* package installs properly
* rpmlint :
php-channel-ezc.src:21: W: unversioned-explicit-provides php-channel(ezc)
php-channel-ezc.src:22: W: unversioned-explicit-provides
php-channel(%{channel})
* final provides are sane:
php-channel(components.ez.no)  
php-channel(ezc)  
php-channel-ezc = 1-1.fc8
* %check is not present; no test suite provide.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* scriptlets are OK (pear channel..)
* no documentation 

No version for the .xml file, but I think using 1 is OK.

Providing php-channel(ezc) is not usefull and should be removed.

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.