[Bug 486905] Review Request: perl-Catalyst-Plugin-Session-State-URI - Saves session IDs by rewriting URIs delivered to the client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486905


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-02-23 02:29:47 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1144956
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
89d5967c47b3563cfadd3dfc48611862  Catalyst-Plugin-Session-State-URI-0.08.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=7, Tests=100,  1 wallclock secs ( 0.02 usr  0.01 sys +  0.77 cusr  0.17
csys =  0.97 CPU)
+ Package perl-Catalyst-Plugin-Session-State-URI-0.08-1.fc11-noarch =>
  Provides: perl(Catalyst::Plugin::Session::State::URI) = 0.08
  Requires: perl(HTML::TokeParser::Simple) perl(MIME::Types) perl(MRO::Compat)
perl(URI) perl(URI::Find) perl(URI::QueryParam) perl(base) perl(strict)
perl(warnings)

Suggestions:
1) drop BuildRequires:  perl >= 1:5.8.0 from SPEC file 
2) remove following requires
Requires:       perl(Catalyst::Plugin::Session) >= 0.06

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.