[Bug 484560] Review Request: pydb - An expanded version of the Python debugger

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484560


Jon Levell <fedora at coralbark.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at coralbark.net




--- Comment #1 from Jon Levell <fedora at coralbark.net>  2009-02-24 18:02:18 EDT ---
This is just an informal review:

1) Using rpmlint on your spec file shows that for the main package you have
omitted the %defattr section. It should be 
%defattr(-,root,root,-)

2) For the emacs subpackage, the defattr line should also be changed to the
above.

3) The license tag should be GPLv2+ as the copyright headers allow you to use
the code under a later version.

4) building the package with mock and running rpmlint on the resulting rpms
gives warnings:
rpmlint -i emacs-pydb-1.25-3.fc10.noarch.rpm
emacs-pydb.noarch: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

and 

rpmlint -i pydb-1.25-3.fc10.noarch.rpm
pydb.noarch: W: symlink-should-be-relative /usr/bin/pydb
/usr/lib/python2.5/site-packages/pydb/pydb.py
Absolute symlinks are problematic eg. when working with chroot environments.

The first is border-line:
https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#no-documentation
but the COPYING file should probably be included in at least one of the rpms

The second can be fixed by following an example like:
http://cvs.fedora.redhat.com/viewvc//rpms/python-kid/devel/python-kid.spec?view=markup


Other than the above, the rest looks fine.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.