[Bug 226413] Merge Review: setuptool
bugzilla at redhat.com
bugzilla at redhat.com
Fri Feb 27 10:09:03 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=226413
--- Comment #1 from Michal Nowak <mnowak at redhat.com> 2009-02-27 05:09:01 EDT ---
> Conflicts: pam < 0.78
Can be deleted, for Fedora at least.
> You should install the setuptool package because you may find
> yourself using its features for essential system administration.
Kinda funny.
> %configure
Needs fix, see at the bottom.
> make
https://fedoraproject.org/wiki/Packaging:Guidelines#Parallel_make
> %defattr(-,root,root)
Use: %defattr(-,root,root,-)
> %doc README
Missing COPYING.
%attr(0755,root,root) %{_bindir}/setup
%attr(0644,root,root) %{_sysconfdir}/pam.d/*
%attr(0644,root,root) %{_sysconfdir}/security/console.apps/*
%attr(0755,root,root) %{_sbindir}/setup
%attr(0755,root,root) %dir %{_datadir}/%{name}
%attr(0755,root,root) %dir %{_datadir}/%{name}/setuptool.d
%attr(0755,root,root) %dir %{_sysconfdir}/setuptool.d
%attr(0644,root,root) %{_sysconfdir}/setuptool.d/*
`^^^^^^^^^^^^^^^^^^^^
I don't think you need this that much. Just fix /usr/bin/setup not to have +w
for group & others in the post-install phase and you have it.
RPMLINT
> setuptool.x86_64: W: no-url-tag
If you don't know the correct URI, I will not mind stay in status quo.
> setuptool.x86_64: W: non-conffile-in-etc /etc/pam.d/setup
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99Xconfigurator
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/98system-config-keyboard
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99kbdconfig
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/98netconfig
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99timeconfig
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99system-config-network-tui
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/98system-config-authentication
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99authconfig
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99lokkit
> setuptool.x86_64: W: non-conffile-in-etc /etc/security/console.apps/setup
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99ntsysv
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99sndconfig
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99mouseconfig
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/98system-config-display
> setuptool.x86_64: W: non-conffile-in-etc /etc/setuptool.d/99printconf-tui
This could be %config, if not %config(noreplace), at least.
> setuptool.x86_64: W: unstripped-binary-or-object /usr/sbin/setup
+
> [...]
> gcc -DHAVE_CONFIG_H -DGETTEXT_PACKAGE=\"setup\" -DSETUPTOOLDDIR=\"/etc
> /setuptool.d\" -DOTHERSETUPTOOLDDIR=\"/usr/share/setuptool/setuptool.d\"
> -I. -Wall -Wextra -O2 -g -MT setup.o -MD -MP -MF .deps/setup.Tpo -c -o
> setup.o setup.c
The setuptool build system does not honor Fedora compiler flags. Even though -g
is present the -debuginfo pkg is not written.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
More information about the Fedora-package-review
mailing list