[Bug 485159] Review Request: anki - Flashcard program for using space repetition learning

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=485159


Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+




--- Comment #5 from Tom "spot" Callaway <tcallawa at redhat.com>  2009-02-27 15:46:58 EDT ---
== Review ==

Good:

- rpmlint checks return:
anki.src: W: strange-permission generate-anki-tarball.sh 0755
Safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (GPLv3+ and MIT) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86_64)
- no missing BR
- no unnecessary BR
- locales okay
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime 
- desktop file okay

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.