[Bug 487114] Review Request: gvrpcd - A program for announcing VLANs using GVRP.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=487114





--- Comment #2 from Michael Schwendt <bugs.michael at gmx.net>  2009-02-28 04:14:52 EDT ---
* Patches have been merged upstream into gvrpcd-1.2, which does not
exist as tarball release yet, though.


Quite a lot of issues with this package:

* %{_sysconfdir}/sysconfig/gvrpcd

  - must not be executable

  - is a configuration file that ought to be marked %config(noreplace)

  - defaults to "eth0" (why?) 

  - the default is also a bit strange considering that the
    initscript defaults to eth0 already

  https://fedoraproject.org/wiki/Packaging/Guidelines#Configuration_files


* rpmlint /home/qa/tmp/rpm/RPMS/gvrpcd-1.1-2.fc10.i386.rpm
gvrpcd.i386: E: script-without-shebang /etc/sysconfig/gvrpcd
gvrpcd.i386: E: init-script-without-chkconfig-postin /etc/rc.d/init.d/gvrpcd
gvrpcd.i386: E: init-script-without-chkconfig-preun /etc/rc.d/init.d/gvrpcd
gvrpcd.i386: W: service-default-enabled /etc/rc.d/init.d/gvrpcd
1 packages and 0 specfiles checked; 3 errors, 1 warnings.

Run "rpmlint -i ..." on the built rpms for helpful explanations.


* Documentation for initscripts can be found here:
https://fedoraproject.org/wiki/Packaging/SysVInitScript
There even is a template you ought to use.


* Upstream is advised to include a proper GPLv2 header as suggested in the
GPL itself. The way it is done currently in gvrpcd.c is doubtful, because it is
a "source" file and the header refers to "this license document". It doesn't
even mention a link to the GPL.


* The README points to  http://wiki.ethereal.com/GVRP  which gives
404 Not Found.


* With defaults, but no /proc/net/vlan/config because of disabled VLAN
interfaces, the daemon logs "fopen: /proc/net/vlan/config: No such file or
directory", says it started successfully, but actually has terminated
(gvrpcd dead but subsys locked). Shutting down prints FAILED, but logs
"shutdown succeeded" and runs into the 8 seconds sleep.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.