[Bug 225612] Merge Review: beagle

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=225612





--- Comment #3 from Adel Gadllah <adel.gadllah at gmail.com>  2009-02-28 06:51:19 EDT ---
(In reply to comment #1)
> Okay, here comes rpmlint on the latest in rawhide:


> beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-windows
> beagle.x86_64: W: non-conffile-in-etc /etc/beagle/config-files/BeagleSearch.xml
> beagle.x86_64: W: non-conffile-in-etc /etc/beagle/query-mapping.xml

OK, done.

> beagle.x86_64: W: non-conffile-in-etc
> /etc/xdg/autostart/beagled-autostart.desktop

Not sure if this should be threated like a config file...

> beagle.x86_64: W: non-conffile-in-etc
> /etc/beagle/crawl-rules/crawl-applications
> beagle.x86_64: W: non-conffile-in-etc /etc/beagle/config-files/Networking.xml
> beagle.x86_64: W: non-conffile-in-etc /etc/beagle/blocate.conf
> beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-monodoc
> beagle.x86_64: W: non-conffile-in-etc /etc/beagle/external-filters.xml.sample
> beagle.x86_64: W: non-conffile-in-etc /etc/beagle/config-files/Daemon.xml
> beagle.x86_64: W: non-conffile-in-etc
> /etc/beagle/crawl-rules/crawl-documentation
> beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-executables
> beagle.x86_64: W: non-conffile-in-etc
> /etc/beagle/config-files/FilesQueryable.xml
> beagle.x86_64: W: non-conffile-in-etc /etc/beagle/crawl-rules/crawl-manpages
> 
> Please mark all of these as %config(noreplace).

OK, done.

> beagle.x86_64: E: non-executable-script /usr/lib64/beagle/keygrabber.py 0644
> 
> Please fix permissions on that script.

OK, done

> beagle.x86_64: W: non-standard-uid /var/cache/beagle beaglidx
> beagle.x86_64: W: non-standard-gid /var/cache/beagle beaglidx
> beagle.x86_64: W: non-standard-uid /var/cache/beagle/indexes beaglidx
> beagle.x86_64: W: non-standard-gid /var/cache/beagle/indexes beaglidx
> 
> Safe to ignore.
> 
> beagle.x86_64: W: devel-file-in-non-devel-package /usr/bin/beagle-config
> beagle.x86_64: W: devel-file-in-non-devel-package
> /usr/lib64/beagle/libbeagleglue.so
> 
> beagle.x86_64: E: explicit-lib-dependency libbeagle
> 
> Safe to ignore. Odd that it doesn't end up building against libbeagle though.

Is linked at runtime (dlopen)

> beagle-epiphany.x86_64: E: non-executable-script
> /usr/lib64/epiphany/2.24/extensions/beagle.py 0644
> 
> Please fix permissions on that script.

Fixed.

> beagle-firefox.x86_64: E: script-without-shebang
> /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/locale/zh-CN/contents.rdf
> beagle-firefox.x86_64: E: script-without-shebang
> /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/beagleAddFilter.xul
> beagle-firefox.x86_64: E: script-without-shebang
> /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/indexLink.xul
> beagle-firefox.x86_64: E: script-without-shebang
> /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/skin/classic/overlay.css
> beagle-firefox.x86_64: E: script-without-shebang
> /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/utils.js
> beagle-firefox.x86_64: E: script-without-shebang
> /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/locale/zh-CN/beagle.dtd
> beagle-firefox.x86_64: E: script-without-shebang
> /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/content/beagleAddFilter.js
> 
> Are these really executable scripts? Do they need to be chmod +x?

No, fixed.

> beagle-firefox.x86_64: E: wrong-script-end-of-line-encoding
> /usr/lib64/mozilla/extensions/{ec8030f7-c20a-464f-9b0e-13a3a9e97384}/{fda00e13-8c62-4f63-9d19-d168115b11ca}/chrome/locale/zh-CN/contents.rdf
> 
> Please fix the end of line encoding here. sed -i 's/\r//' foo
> 
> beagle-firefox.x86_64: E: only-non-binary-in-usr-lib
> beagle-gnome.x86_64: W: no-documentation
> 
> Safe to ignore.
> 
> beagle-gnome.x86_64: W: devel-file-in-non-devel-package
> /usr/lib64/beagle/libbeagleuiglue.so
> 
> You should have a beagle-gnome-devel package for this one.

No this file gets dlopened its not something that is linked against at build
time.

> beagle-thunderbird.x86_64: W: no-documentation
> beagle-thunderbird.x86_64: E: only-non-binary-in-usr-lib
> 
> Safe to ignore.
> 
> *****
> 
> Please make the changes that I illustrated from rpmlint, and I'll finish the
> review.

Thanks, fixed in 0.3.9-4

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.