[Bug 188542] Review Request: hylafax

bugzilla at redhat.com bugzilla at redhat.com
Sat Feb 28 22:26:11 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=188542





--- Comment #99 from Lee Howard <faxguy at howardsilvan.com>  2009-02-28 17:25:57 EDT ---
SPEC: http://downloads.sourceforge.net/hylafax/hylafax.spec
SRPM: http://downloads.sourceforge.net/hylafax/hylafax-5.2.9-1.src.rpm

> * As the package is already hylafax, You don't need to have
> Provides:  hylafax

Removed.

> * BuildRequires: ... gcc, gcc-c++ - Those aren't needed as they are implicitly
> added in the BuildDependency and shouldn't be mentioned. (older fedora version
> will need this indeed).

Left as-is to support older Fedora.

> * Conflicts:   mgetty-sendfax - We need to find a solution to avoid conflict.
> and implement a proper alternative. Since this can probably not hit F-9/F-10

HylaFAX was in RedHat 5.2.  mgetty-sendfax chose to develop its own "sendfax"
command-line fax tool using the same "sendfax" name as HylaFAX (as well as the
same /var/spool/fax spool directory - HylaFAX has since changed to
/var/spool/hylafax).  Because of this conflict RedHat removed HylaFAX beginning
at 6.0.  The conflict cannot be resolved because it was the mgetty-sendfax
developer's intention to create an alternative for HylaFAX.

I do not wish to offend Gert Doering, but it is my recommendation to remove
mgetty-sendfax from Fedora.  (Mostly because the last official release, 1.0, is
dated 1998... although betas are available from 2007.)  However, as I suspect
that my recommendation will not be followed, it is therefore my suggestion to
implement a "system-switch-fax" similar to what has been done for
sendmail/Postfix.

*IF* doing that work will finally get this package into Fedora - with no more
hold-ups, then I will gladly go through the effort to develop system-switch-fax
and make the necessary modifications to both the mgetty-sendfax package and
this package.  *HOWEVER*, I do not desire to go through that effort only to
find that we're yet hung up on something else.

Please advise.

> * http://koji.fedoraproject.org/koji/getfile?taskID=1068404&name=build.log
> - JBIG library was not found on x86_64
> Checking for JBIG library support
> ... not found. Disabling JBIG support
> Can the support for this can be enabled ? (it needs to be added as
> BuildRequires first)

The JBIG-KIT package is currently not in Fedora.  Other distributions (i.e.
Gentoo) do include it.  However, there may be some patent encumbrances with
respect to JBIG technology, and you may want to pass this with your legal team
before including JBIG-KIT into Fedora.

> * Various checks are made at build time:
> WARNING, could not locate sendmail on your system.
> Beware that the mail notification work done by this software uses
> sendmail-specific command line options.  If you do not have a
> sendmail-compatible mailer things will break.
> ...
> WARNING, no egetty program found, using /bin/egetty.
> ...
> Looks like /usr/bin/gs is the PostScript RIP to use.
> WARNING, /usr/bin/gs does not seem to be an executable program;
> 
> -> Does the necessary Requires: are requested for the runtime ?
> either using Requires on the package, or the "virtual provides" or on the
> program path name.

The warnings can be ignored.  The Requires: should be sufficient, yes.  Those
packages are not needed for building this package, but they are needed for
runtime.

> -> the cron scripts should probably stay as %config files 
> -> the undefined-non-weak-symbol /usr/lib64/libfaxserver.so.5.2.8
> HYLAFAX_VERSION_STRING can probably be fixed.

Please advise on how it can probably be fixed.

> * --with-PAGESIZE=A4 - I appreciate that my standard page format to be set as
> default, but is there a way to have this fixed at runtime while using system
> wide configuration files for localization ? (I haven't made runtime test, as
> i don't have the required hardware/phone connection.

Yes, the defaults can be changed at runtime.  I'm not sure there is an issue
here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.




More information about the Fedora-package-review mailing list