[Bug 476460] Review Request: pymilter - Python interface to sendmail milter API

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=476460


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-01-02 11:19:08 EDT ---
Some notes:
- Please remove unneeded macros or conditions which are not related
  to Fedora 
  * especially rh7 age condition is not needed
  * And I don't think aix4.1 part is needed.

- Also please explain why you want to introduce %name, %version or %release
  macro (note that when you write "Version: 0.9.0", the %version macro
  is automatically defined (and same for %name, %release)

- For source tarball hosted by sourceforge.net, please follow
  https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net

- Remove "Vendor" item. This is automatically set when rebuiding
  your srpm on Fedora site.

- Your srpm does not build
  * One reason is that "BuildRequires: ed" is missing
    http://koji.fedoraproject.org/koji/taskinfo?taskID=1029717
  * The second reason is that "%_libdir/libmilter.a" (in sendmail-devel)
    is not compiled with -fPIC. So either
    - C module support for this package should be dropped
    - Or you should file a bug against "sendmail" to compile
      libmilter.a with -fPIC (I guess filing a bug is better
      anyway)

- "%files -f INSTALLED_FILES" in your method is not allowed on
  Fedora, because with this method all needed directories under
  python sitelib/sitearch directory are not owned correctly:
  https://fedoraproject.org/wiki/Packaging/Python#System_Architecture
  https://fedoraproject.org/wiki/Packaging/UnownedDirectories

- We now recommend %defattr(-,root,root,-)

- The directory %libdir is not owned by this package
  (again please refer to "UnownedDirectories" wiki page)

- "%config" file should be under %_sysconfdir (/etc) and files
  under %_libdir should not be marked as %config.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.