[Bug 478470] Review Request: mrpt - The Mobile Robot Programming Toolkit (MRPT)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478470


Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mtasaka at ioa.s.u-tokyo.ac.jp




--- Comment #2 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-01-02 12:45:43 EDT ---
Some notes
- First of all, your package does not build:
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1029717
  So I just check your spec file

- After some long discussion, many Fedora contributors say that
  including the package name itself in its Summary is redundant.

- By the way, is it really needed that the most part of %description
  is repeated on every subpackage?

- For source tarball:
  I cannot see rev.714 tarball on the URL. Also your versioning
  of this srpm is not proper for Fedora. Please refer to
  https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control
  https://fedoraproject.org/wiki/Packaging/NamingGuidelines#SnapshotPackages

  ! Also please consider to use %{?dist} tag:
    https://fedoraproject.org/wiki/Packaging/DistTag

- Please remove "Packager" item. This is automatically defined when
  rebuilding this srpm on Fedora site.

- "%package -n mrpt-ann" can simply be replaced by "%package ann" (same
  for other subpackages)

- Usually the dependencies between packages created from the same srpm
  must be EVR (Epoch:Version:Release) specific, not just name specific
  (i.e. usually should have "Requires: %{name}-mrpt = %{version}-%{release}",
   for example).

- Packages containing pkgconfig .pc file must have "Requires: pkgconfig"
  (ref:
   https://fedoraproject.org/wiki/Packaging/ReviewGuidelines )

- Currently I am not sure if koji supports noarch subpackages build
  when main package is arch dependent, however for now I doubt this
  (and other packages don't this so).
  So please remove "BuildArch: noarch" for -doc subpackage.

- Make build.log more verbose (to check if compiler options are correctly
  honored, for example). "make VERBOSE=1" seems to work for this package
  (ref:
   https://fedoraproject.org/wiki/Packaging/cmake )

- Pleae call "make documentation_html" at %build stage
  (By the way, why is it needed to call "make %?_smp_mflags" at %install ?)

- Please take care of directory ownership issue.
 
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
  https://fedoraproject.org/wiki/Packaging/UnownedDirectories
  - This package must not own %{_datadir}/applications/,
    %{_libdir}/pkgconfig or so
  - Instead %_datadir/%name is not owned by any packages

- %post -n mrpt-apps -p '/usr/bin/update-mime-database /usr/share/mime'
  This cannot be done (you can simply think that this method can be
  used only for calling /sbin/ldconfig with no other additional
  scripts)

- For %changelog format, please follow
  https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.