[Bug 478659] Review Request: xfce4-screenshooter - Screenshot utility for the Xfce desktop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478659


Kevin Fenzi <kevin at tummy.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #2 from Kevin Fenzi <kevin at tummy.com>  2009-01-03 01:04:17 EDT ---
OK - Package meets naming and packaging guidelines
OK - Spec file matches base package name. 
OK - Spec has consistant macro usage. 
OK - Meets Packaging Guidelines. 
OK - License (GPLv2+)
OK - License field in spec matches
OK - License file included in package
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
1bcd5d2e7428c7ced039be87dfa30d74  xfce4-screenshooter-1.4.90.0.tar.gz
1bcd5d2e7428c7ced039be87dfa30d74  xfce4-screenshooter-1.4.90.0.tar.gz.orig
OK - BuildRequires correct
OK - Spec handles locales/find_lang
OK - Package has %defattr and permissions on files is good. 
OK - Package has a correct %clean section. 
OK - Package has correct buildroot
OK - Package is code or permissible content. 
OK - Packages %doc files don't affect runtime. 
OK - Package has rm -rf RPM_BUILD_ROOT at top of %install

OK - Package is a GUI app and has a .desktop file

OK - Package compiles and builds on at least one arch. 
OK - Package has no duplicate files in %files. 
OK - Package doesn't own any directories other packages own. 
OK - Package owns all the directories it creates. 
See below - No rpmlint output. 
OK - final provides and requires are sane

SHOULD Items:

OK - Should build in mock. 
OK - Should build on all supported archs
OK - Should have subpackages require base package with fully versioned depend. 
OK - Should have dist tag
OK - Should package latest version

Issues: 

1. rpmlint says: 
xfce4-screenshooter-plugin.x86_64: W: no-documentation

which can be ignored. 

2. I see you have
--add-only-show-in=XFCE
in the desktop file. Is that really intended?
Doesn't that lessen the need for splitting out the plugin, if 
it's only going to be used in Xfce anyhow? On the other hand, other 
DE's have their own screenshot applications, so perhaps thats adding too much 
clutter. In any case, up to you. 

Neither of these are blockers, so this package is 
APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.