[Bug 459946] Review Request: pfscalibration - Scripts and programs for photometric calibration

bugzilla at redhat.com bugzilla at redhat.com
Sat Jan 3 19:27:40 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459946





--- Comment #7 from Ulrich Drepper <drepper at redhat.com>  2009-01-03 14:27:39 EDT ---
(In reply to comment #6)
> nrutil.cpp and nrutil.h are public domain.
> (http://www.nr.com/public-domain.html)
> I do not think there is need for patch1.

The files used in the package are not on the list.  This might be an oversight
but it's really not necessary to bicker about this.  The code is using so
little from these files it's absolutely unnecessary to pull in so much code.
The patch is also an optimization.


> Source0 URL is still wrong, it should be:
> 
> http://downloads.sourceforge.net/pfstools/%{name}-%{version}.tar.gz

That's not what the URL referenced in comment #4 says and it shouldn't matter:

  http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz

This works just as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list