[Bug 478674] Review Request: pp3 - Creation of sky charts in Postscript or PDF format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478674





--- Comment #1 from Lubomir Rintel <lkundrak at v3.sk>  2009-01-04 18:22:41 EDT ---
1.) Please do not strip the packages while %install-ing
The debuginfo is generated empty.

export CXXFLAGS="%{optflags} -s"
make %{?_smp_mflags}

Why do you add -s there? You should not strip the debugging symbols off the
binaries. Tip: Besides environment variables, make takes initial variable
values also from command line:

make %{?_smp_mflags} CXXFLAGS="%{optflags}

2.) The manual contains also images, but you include only *.html in the
package. You may want to wget -p it, generate a tarball and Source it along
with the comment on how did you generate it. Tip: Work with upstream -- they
may be willing to include documentation in the source tarball in next release.
They may also be willing to include information on how to install it in Fedora,
since the manual has "RPM installation section"

3.) You patch for gcc 4.3 compatibility, not 3.4 (I guess) ;)

4.) You don't have to patch makefile just to override variables. Just unset
them on command line! (see 1.)

By the way -- why do you patch info installation away? Please comment!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.